search

icytornado / pe

0 stars 0 forks source link

select command feature flaw #5

Open icytornado opened 3 years ago

icytornado commented 3 years ago

steps to reproduce:

  1. select all
  2. select 1

expected: after the second select, one 1 is selected, the rest should be unselected

actual: all are still selected

comment: will be unconvenient for the user, as everytime they have to select clear before selecting anyting.

Screenshot 2021-04-16 at 2.57.38 PM.png

nus-pe-bot commented 3 years ago

Team's Response

One of the intended use case of select is as follow

  1. find Tom
  2. select shown
  3. find Jerry
  4. select shown
  5. email selected

Emails to all Toms and Jerrys.

Proposed change does not allow for the above use case.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Dev Team's response does not address the problem that i raised. Select 1 followed by select 2 resulting in incremental selection is correct. However, the problem lays in the 'select all' command. Whenever, 'select all' command is followed by another select command, the exising selected persons should be unselected. Therefore, it is the 'select all' command that is causing the trouble. Any other select command following the 'select all' command should not follow incremental selection, because the 'select all' command has already selected all of the persons.

Furthermore, as stated in the dev team's response, after the 'email selected' command, Tom and Jerry should be unselected, because the operation on them is already finished after the 'email selected' command. However, Tom and Jerry are still selected after the operation and have to be cleared using the 'select clear' command if im not wrong. Therefore, this team's selection mechanism should be revised. i.e. 1) after the operation is done on the selected persons, the persons should be unselected. 2) Any other select command after the 'select all' command should unselect the selected persons first and then select the indicated person. The team should revise their definition on incremental selection according to these 2 points, and revise their implementation accordingly. Only then, the app will be more convenient for the users to use.