search

icza / scelight

The source code of the Scelight project with all its modules.
https://sites.google.com/site/scelight/
Apache License 2.0
124 stars 19 forks source link

missing support for replay packs released for AI devs #11

Closed keiras closed 6 years ago

keiras commented 7 years ago

Replays from the replay pack (https://github.com/Blizzard/s2client-proto#downloads) are not parsable by Scelight. I suspect it is because of the anonymization effort made by Blizzard. Here is an example replay from the pack ex_anon_replay.zip

When looking through the code, the issue seems to be in RepParserEngine.java#L118 where mpqParser.getFile( RepContent.DETAILS ) evaluates to null.

Would it be possible to look into this issue and add support for this kind of replay files?

icza commented 7 years ago

If mqParser.getFile( RepContent.DETAILS ) returns null, that most likely means the replay.details section is removed from the replays, and most likely other parts too. Scelight heavily depends on the content of these parts, so I don't make any promises. I'll look into it when I have time.

keiras commented 7 years ago

Hi, I have managed to find some of my replays in the anonymized pack. I thought it might be useful for you, so I am sending you two pairs of replays. Each pair consist of a hash-named replay from the pack and an equivalent replay saved by the SC2 client after finishing the game (they have the same elapsedGameLoops count).

I hope it will help you.

replays-paired.zip

note: I got basic replay info (mmr, win/loss, apm, race, map, gameLoops) about the anonymized replay batch using pysc2.bin.replay_info in https://github.com/deepmind/pysc2

icza commented 6 years ago

Released Scelight 6.4.0 which adds support for anonymized replays.