icza / screp

StarCraft - Brood War replay parser
Apache License 2.0
80 stars 21 forks source link

How to determine SC1 replay format (v16 or v17+/scr) #31

Closed captain-majid closed 2 years ago

captain-majid commented 2 years ago

I think the output json Header/Engine should contain that info, but ig its always BW.

icza commented 2 years ago

The Header.Engine field tells whether the game was played using Original StarCraft or the Brood War extension, therefore its value may be "SC" (for Original) or "BW" (for Extension). This is independent of the version, you could use the original or extension with old and new versions too.

captain-majid commented 2 years ago

Well nobody plays on the vanilla (Original) anymore, except maybe just the campaign, so ig Header/Engine isn't very useful to refer to the BW (Expansion) which is almost all the replays, I mainly use SC v1.16, not v1.17+ (SCR), and I appreciate if the replay format can be distinguished between the two versions.

Also BWChart defines the Engine field as I'm expecting, it'll be more useful if you can change screp/repmastered.app this way: bwchart

icza commented 2 years ago

The Original StarCraft is still popular amongst fastest players, so it is still useful.

But I agree the version info would also be useful. Note that the replay version is not stored in the replay. "Guessing" the replay version based on the replay date is unreliable as the date cannot be trusted. Some version "categories" can be distinguished which I will add to screp and repmastered.app.

icza commented 2 years ago

There ya go: https://github.com/icza/screp/releases/tag/v1.7.3

Added a Header.Version field, quoting its documentation:

// Version contains information about the replay version.
// Since version is not stored in replays, this only designates certain version ranges deducted from replay format.
// Current possible values are:
//   - "-1.16": version is 1.16 or older
//   - "1.18-1.20": version is 1.18..1.20
//   - "1.21+": version is 1.21 or newer
Version string
icza commented 2 years ago

Also added to repmastered.app.

Details: https://repmastered.app/news

captain-majid commented 2 years ago

Great news, thanks.