icza / screp

StarCraft - Brood War replay parser
Apache License 2.0
80 stars 21 forks source link

When spam is calculated ? #54

Closed captain-majid closed 5 months ago

captain-majid commented 11 months ago

I've played a game vs Computer and tried to reproduce some spam actions to see what do what, but nothing was recorded as "IneffKind" in the generated json file, I tried to play a longer game, still nothing, any idea ?

icza commented 11 months ago

The rules for inefficient commands are detailed here: https://repmastered.app/faq

Q: What is EAPM, and how is it calculated? A: EAPM stands for Effective APM. EAPM excludes commands from the APM calculation that are considered to be ineffective such as:

  • Unit queue overflow: training units that cannot fit into the queue
  • "Immediately" (dt < ~0.8s) cancelling a unit or upgrade
  • Repeating certain commands too fast (dt < ~0.4s) such as Stop, Hold, Attack, Set Rally etc.
  • Changing selection or reselecting the same units too fast (dt < ~0.3s); note: double-tapping a hotkey group to center the group is not considered ineffective
  • Repeating certain commands (without time restriction) such as Morph, Upgrade, Merge Archon, Lift off, Cancel Build etc.
  • Repeating the same Hotkey Add or Assign command
captain-majid commented 11 months ago

I've read that FAQ, still don't know the issue, this is the replay, if it helps: https://repmastered.app/game/Z0VXziju4YUy3XPF92sSplNRUMJn4h7dmJwnwG2g9zE?tab=players

icza commented 11 months ago

What don't you understand? Please ask a specific question. Your commands are not marked as ineffective because no rule is matching those patterns.

captain-majid commented 11 months ago

I don't know actually, this is another example: https://repmastered.app/game/wevM1SVAJwWYzdwCzW9BWLkplYf3dEdv49txO-rAYPg?tab=commands

I've tried to do a very fast Right Click while selecting a Nexus/Hatchery, to Set Rally, but sometimes its normal Right Click cmd like in the above replay, and other times its Targeted Order/RallyPointTile, I also tried to do unstoppable same Hotkey Assign to increase APM enormously, by leaving my fingers on Ctrl+1 or Ctrl+2 for long time, but I end up with 0 spam.

Maybe the real conundrum is that I didn't do any of the repetitive Select cmd between every Set Rally or Hotkey Assign, I didn't even change focus, so I don't know why the heck this Select cmd interrupts every spam action !!!

I even disabled CoachAI, which is a thing I never do, but still, maybe I'm protected from spam detection ? :smile:

icza commented 11 months ago

There is a "Select" action after each of your commands, that's probably a 3rd party software, not your doing. That's likely why no inefficient action is detected. Try to assign some units to a hotkey (e.g. 1), and press and hold down the 1 key to spam "selecting" it. It surely will end up as inefficient, unless something your computer keeps selecting units in between.

captain-majid commented 11 months ago

Nothing changed, but at least its not a screp issue, thanks for help.