id / zookeeper-el7-rpm

A set of scripts to package Apache Zookeeper into an rpm (CentOS/RedHat 7)
73 stars 51 forks source link

Changes from #3 and a few more improvements #16

Open thias opened 4 years ago

thias commented 4 years ago

See #3 (which can probably be closed) for the initial discussion. I've added the ability to use something like make NAME=zookeeper34 to override the package name, allowing it to co-exist with others inside a single repository. It doesn't allow to be parallel installed, but it can be useful nevertheless (with 3.5.x, for instance). For this to work, I had to revert a lot of the %{name} usage introduced recently... it typically seems like a good idea to use %{name}, but IMHO it usually isn't: It theoretically increases spec file "reusability" for other projects, but little more, and gets in the way once you want to rename a package like in this case.

I have this modified package running on some servers just fine, but feel free to test in depth, double check, adapt as needed and ask about anything that could be unclear.

There have been no changes to the noreplace config files, so updating should always be smooth. This is also the reason why the CLASSPATH is set in the systemd service file and not the sysconfig file.

id commented 4 years ago

@thias sorry for delayed response.

The fact is, I'm no longer running Kafka/Zookeeper as part of my daily job for quite some time, and in general moved away from building my own RPMs and operating services.

If I am to call for maintainers for possible handover of this project, would you be interested? Right now I feel this patch has too many significant changes to make a decision whether to merge it into this repo or not.

mator commented 4 years ago

@id

probably would be nice to push some changes to README (somewhere in the top of it) announcing about repo status and search for a new maintainer...

PS: Besides, you always could merge simple PRs which does not change core functionality of the package