idaholab / FORCE

The Framework for Optimization of ResourCes and Economics is a collection of software tools, models, and datasets acquired and developed under the Integrated Energy Systems (IES) program to enable analysis of technical and economic viability of myriad IES configurations. FORCE is the consolidating interface and data repository for all the IES toolsets ranging from macro technoeconomic analysis to transient process modeling and experimental validation for integrated energy systems.
MIT License
8 stars 13 forks source link

Fixed function to create components node if missing #16

Closed caleb-sitton-inl closed 4 months ago

caleb-sitton-inl commented 4 months ago

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

15

What are the significant changes in functionality due to this change request?

When a HERON XML script containing no <Components> node is input to the src/heron/create_componentsets_in_HERON() function, the function now adds a new <Components> node. It also prints a message stating that the addition was made. This mirrors the function's behavior when dealing with input scripts that are missing <economics> or <CashFlow> nodes.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

GabrielSoto-INL commented 4 months ago

could you fix the typo on this line? https://github.com/idaholab/FORCE/pull/16/files#diff-e5a05e2d7232d1a807b092ef316d5d19d9eaec4b6043a74cd4dd42512f90daa2R34

GabrielSoto-INL commented 4 months ago

And I believe the multi-line strings like the input in this docstring should be indented at least to the comma on the previous line (it was bothering me and might as well ask since you're already editing the file!): https://github.com/idaholab/FORCE/pull/16/files#diff-e5a05e2d7232d1a807b092ef316d5d19d9eaec4b6043a74cd4dd42512f90daa2R36