[DEFECT] Component capacity defined through over component's capacity

mgarrouste commented 2 years ago

Defect Description

Describe the defect I defined one component capacity ('dependent') using another component capacity ('main').

What did you expect to see happen?

The case running

What did you see instead?

The case crashed, the template driver does not put the dependent capacity in the right spots in the inner and outer files.

Do you have a suggested fix for the development team?

Once the sampler has sampled another capacity for the main component the dependent capacity should be computed from the main one and then written as a constant in the inner file

Describe how to Reproduce Steps to reproduce the behavior:

Run the file attached in HERON

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

dependent_capacity.xml.zip

Platform (please complete the following information):

OS: [e.g. iOS]
Version: [e.g. 22]
Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

PaulTalbot-INL commented 2 years ago

To understand, you have one component such as

  <Component name="alpha">
    <capacity>
      <fixed_value>5</fixed_value>
    </capacity>
    ....
  </Component>

and another such as

  <Component name="beta">
    <capacity>
      <variable>alpha_capacity</variable>
    </capacity>
    ....
  </Component>

?

mgarrouste commented 2 years ago

Not exactly the first component capacity is part of the optimization So something like this: `

0,5

....

`

and another such as `

alpha_capacity

....

`

PaulTalbot-INL commented 2 years ago

That is a very challenging pattern. It's definitely possible on the RAVEN side to tie these capacities together, but HERON definitely isn't set up like that. I'll have to think about how we could do this.

idaholab / HERON