idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

Farm delta #192

Closed wanghy-anl closed 2 years ago

wanghy-anl commented 2 years ago

Pull Request Description

What issue does this change request address?

Added validator portal for FARM_Delta_FMU

What are the significant changes in functionality due to this change request?

In Windows OS, HERON can now perform validation using FARM_Delta_FMU, which supports MIMO FMU as high-fidelity downstream model.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

wanghy-anl commented 2 years ago

@dgarrett622 @PaulTalbot-INL Daniel and Paul, this PR includes the validator portal to FARM_Delta_FMU. The validator code has been merged to FARM repo, and the FARM submodule version has been updated in raven. Could you review and merge this PR? Then once you updates the HERON submodule version in raven, the FARM_Delta_FMU will be officially available. Thanks, Haoyu

PaulTalbot-INL commented 2 years ago

Hi @wanghy-anl, an issue should be referenced by this PR. Generally an issue should be opened before new development begins, but you can open one now to cover the feature request that this PR satisfies.

wanghy-anl commented 2 years ago

Hi @wanghy-anl, an issue should be referenced by this PR. Generally an issue should be opened before new development begins, but you can open one now to cover the feature request that this PR satisfies.

Done. See #193

wanghy-anl commented 2 years ago

@PaulTalbot-INL Hello Paul, it seems that all the checks have passed. Could you merge this PR? It would be great if you could update the HERON submodule version in raven to reflect this change, but that's not a rush. Thanks, Haoyu