idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

[DEFECT] Economic parameters cannot be specified with anything but <sweep_values> subnode #225

Open j-bryan opened 1 year ago

j-bryan commented 1 year ago

Defect Description

Describe the defect

What did you expect to see happen?

Model to be evaluated at specified sweep values. Documentation indicates is an accepted subnode for (see provided heron_input.xml).

What did you see instead?

Error when calculating economics due to specified sweep values being a list. The end goal here is to be able to specify a range of economics values as part of a sensitivity analysis.

Do you have a suggested fix for the development team?

The swept economics values could probably be evaluated after the dispatch optimization in RAVEN and addressed within HERON while the economic metrics are being calculated. The standard dispatch optimization doesn't seem to rely on the values specified in the node, so adding these to the sampling grid in RAVEN (outer.xml) would duplicate design points which do affect dispatch. I'm not sure if optimizing these values would ever make sense (i.e. using to specify values) for these nodes.

Alternative, just amend , , and to accept only the subnode.

Describe how to Reproduce Steps to reproduce the behavior:

  1. Use node to specify values for
  2. Run model with HERON, then RAVEN.

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

HERON input XML file and relevant out~inner file with error messages changed to .txt to allow upload and are attached.

Platform (please complete the following information):


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

PaulTalbot-INL commented 1 year ago

This is an excellent feature request (or defect we should not claim as a current feature). We had FY23 scope proposed for this activity this year, but it has not been funded yet as of this note. We think stochastically treating the costing data could be very valuable in capturing the expected economic efficacy of portfolios.

j-bryan commented 1 year ago

Am I right in thinking that we could address that uncertainty after we've done the dispatch optimization? Seems like it would be relatively easy to implement and computationally inexpensive.

PaulTalbot-INL commented 1 year ago

Yes, it is independent (and linear) from the dispatch optimization so it should be almost completely trivial to handle quickly if we set it up right.