Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24
stars
38
forks
source link
[DEFECT] Storage component initial value needs a check during debug run #243
When a HERON case involving a storage component (thermal energy storage in my case) is run in debug mode, the initial value of the component is not checked for when the code is run. This causes HERON to calculate initial charge and discharge rates which come across as unrealistic. This also skews the generated plot and makes the values unreadable for the rest of the parameters.
Do you have a suggested fix for the development team?
If initial storage value is set to a number greater than the maximum capacity of the storage component, then the initial stored value should be set to the max capacity.
If the initial storage value is set to a negative number for some reason, then the value should be replaced by a 0 during initialization.
Describe how to Reproduce
Steps to reproduce the behavior:
Set initial value higher than max storage component's capacity
Run the heron case in debug mode and see the plotted output
Screenshots and Input Files
Word file with the example code has been added. The storage capacity in the example is set to 500 (line 109) whereas the maximum capacity of the storage in debug mode is set to 227.34 (line 105). The resulting plot is also provided as a .png file.
Platform (please complete the following information):
OS: Windows
Version: 10
Dependencies Installation: [CONDA or PIP]
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or
minor?
HERON Code.docx
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.
[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
Defect Description
When a HERON case involving a storage component (thermal energy storage in my case) is run in debug mode, the initial value of the component is not checked for when the code is run. This causes HERON to calculate initial charge and discharge rates which come across as unrealistic. This also skews the generated plot and makes the values unreadable for the rest of the parameters.
Do you have a suggested fix for the development team?
Describe how to Reproduce Steps to reproduce the behavior:
Screenshots and Input Files Word file with the example code has been added. The storage capacity in the example is set to 500 (line 109) whereas the maximum capacity of the storage in debug mode is set to 227.34 (line 105). The resulting plot is also provided as a .png file.
Platform (please complete the following information):
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or
minor?
HERON Code.docx
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.