Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24
stars
38
forks
source link
[DEFECT] HERD amplifies NPV results when running more than 1 scenario #250
When running HERD using the nuclearCase_notebook_match using more than 1 scenario/sampling, the NPV solution should be within a reasonable range of the the solution for 1 scenario and match results from the DISPATCHES jupyter notebook.
Specifically, the results for 1 and 2 samples in the DISPATCHES repository nuclear case notebook are:
N=1, 1.59676063340206e9
N=2, 1.63105178396091e9
What did you see instead?
The results from HERD nuclearCase_notebook_match are amplified when num_arma_samples > 1:
N=1, 1.59402411407554e9
N=2, 3.26420263603555e9
Note: difference between both N=1 results is fine
Do you have a suggested fix for the development team?
When creating the TEAL metrics, I believe something is being duplicated in HERD. Perhaps split the metrics (e.g., NPV) per scenario.
Describe how to Reproduce
Steps to reproduce the behavior:
Change <num_arma_samples>1</num_arma_samples> from 1 to any other integer in the nuclearCase_notebook_match test.
Screenshots and Input Files
Input file:
Platform (please complete the following information):
OS: Windows
Versions: Happens in current HERON, but below are relevant tags to recreate error.
Defect Description
Describe the defect
What did you expect to see happen?
When running HERD using the
nuclearCase_notebook_matchusing more than 1 scenario/sampling, the NPV solution should be within a reasonable range of the the solution for 1 scenario and match results from the DISPATCHES jupyter notebook. Specifically, the results for 1 and 2 samples in the DISPATCHES repository nuclear case notebook are:N=1, 1.59676063340206e9 N=2, 1.63105178396091e9
What did you see instead?
The results from HERD
nuclearCase_notebook_matchare amplified whennum_arma_samples> 1:N=1, 1.59402411407554e9 N=2, 3.26420263603555e9
Note: difference between both N=1 results is fine
Do you have a suggested fix for the development team?
When creating the TEAL metrics, I believe something is being duplicated in HERD. Perhaps split the metrics (e.g., NPV) per scenario.
Describe how to Reproduce Steps to reproduce the behavior:
<num_arma_samples>1</num_arma_samples>from 1 to any other integer in thenuclearCase_notebook_matchtest.Screenshots and Input Files Input file:
Platform (please complete the following information):
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.