idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

HERD NuclearCase MultiPeriod Update #251

Closed GabrielSoto-INL closed 1 year ago

GabrielSoto-INL commented 1 year ago

Pull Request Description

What issue does this change request address?

245

248

250

What are the significant changes in functionality due to this change request?
  1. HERON dependencies have been updated to pip install newest DISPATCHES version (still as an optional dependency)
  2. HERD restructured the build function that creates the Pyomo Multiperiod model to match the newest DISPATCHES release. It now creates a Multiperiod IDAES object that can handle stochastic sets.
  3. Python imports of the DISPATCHES package match the newest re-organization of the DISPATCHES repository.
  4. HERD now uses an intermediate flowsheet_block method to avoid redundant creation of Pyomo Models; instead it creates one model per realization/scenario and for each (time, cluster, year) timestep within that realization it clones from the original.
  5. Fixed error involving wrong NPV values when num_samples > 1. Regolded nuclearCase_Sine test because that was the only test with more than 1 scenario.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 1 year ago

The required tests have passed, checklist clears, merging.