idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

[UNDER-DISCUSSION] Remove Generation of cash.xml #254

Closed dylanjm closed 1 year ago

dylanjm commented 1 year ago

Under Discussion Topic

Summary of the topic to be discussed with the development team

We should remove the generation of cash.xml. It is a feature that had broader plans but has since been abandoned. This is an opportunity for us to reduce code that is not being utilized.

Some users have run into issues caused by the creation of this file when trying to use VPs for capex cashflows (See #173). Although it shouldn't be typical for a user to use a VP for a one-time cash flow, we can see in @mgarrouste case, she has a complicated non-linear function to compute capex, which we should allow users to use our external functions to do.

Describe the solution you'd like to be implemented A clear and concise description of what you want to happen.

Remove the generation of cash.xml in the HERON runtime.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Keeping cash.xml around in case we want to use it directly with TEAL as a separate runtime later.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.