Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22
stars
36
forks
source link
[DEFECT] Taxes & Inflation flags on recurring cashflows don't do anything #265
Currently, a user cannot prevent taxes from being applied to a recurring cash flow. According to TEAL/src/Cashflows.py#L1127, any recurring cash flow is automatically taxed by default.
If a user specifies taxable=False on a <Cashflow> that is recurring, it will apply the tax rate anyway.
In HERON, users have the ability to specify if a cash flow is taxed or not, but in the code, we do not actually pass this information on to TEAL. See HERON/src/DispatchManager.py#L335-L340
This becomes an issue, for example, if a user wants to implement a Production Tax Credit (PTC) for a specific resource on a specific component. This is a recurring cash flow that should not be taxed.
What did you expect to see happen?
What did you see instead?
Do you have a suggested fix for the development team?
Describe how to Reproduce
Steps to reproduce the behavior:
Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.
Platform (please complete the following information):
OS: [e.g. iOS]
Version: [e.g. 22]
Dependencies Installation: [CONDA or PIP]
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.
[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
dylanjm
commented
1 year ago
Defect Description
Describe the defect
Currently, a user cannot prevent taxes from being applied to a recurring cash flow. According to
TEAL/src/Cashflows.py#L1127, any recurring cash flow is automatically taxed by default.If a user specifies
taxable=Falseon a<Cashflow>that is recurring, it will apply the tax rate anyway.In HERON, users have the ability to specify if a cash flow is taxed or not, but in the code, we do not actually pass this information on to TEAL. See
HERON/src/DispatchManager.py#L335-L340This becomes an issue, for example, if a user wants to implement a Production Tax Credit (PTC) for a specific resource on a specific component. This is a recurring cash flow that should not be taxed.
What did you expect to see happen?
What did you see instead?
Do you have a suggested fix for the development team?
Describe how to Reproduce Steps to reproduce the behavior:
Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.
Platform (please complete the following information):
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.