idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

Workbench integration #268

Closed lefebvrera closed 1 year ago

lefebvrera commented 1 year ago

Pull Request Description

What issue does this change request address?

This addresses #259

What are the significant changes in functionality due to this change request?

A new command line option --definition emits the HERON input schema in a format compatible with the NEAMS Workbench.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

lefebvrera commented 1 year ago

@dylanjm I see a precheck has failed but I am unable to determine why. Can you assist me?

dylanjm commented 1 year ago

@lefebvrera looks like the following files contain trailing whitespaces somewhere:

    src/input_definition.py
    src/main.py
dylanjm commented 1 year ago

@lefebvrera looks like there is still trailing whitespace in src/input_definition.py There are usually some editor extensions or features that should remove these white spaces.

lefebvrera commented 1 year ago

@dylanjm I believe I have addressed your comments. Is anything remaining on this PR before we merge?

PaulTalbot-INL commented 1 year ago

@dylanjm is away, but I can finish the review. Checklists pass, comments are addressed, and tests clear. Merging. Thanks for your work!