idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

CashFlow debug outputs #282

Closed PaulTalbot-INL closed 1 year ago

PaulTalbot-INL commented 1 year ago

Pull Request Description

What issue does this change request address?

Closes #281

What are the significant changes in functionality due to this change request?

Uses CashFlow "output" options to provide CSV, plots of CashFlow data, such as the following (from test): Cash_Flows_from_Project_Year_0_to_20 Cumulative_from_Project_Year_0_to_20 Cumulative_pie_from_Project_Year_0_to_20


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 1 year ago

Updated plots with depreciation: Cash_Flows_from_Project_Year_0_to_20 Cumulative_from_Project_Year_0_to_20 Cumulative_pie_from_Project_Year_0_to_20

PaulTalbot-INL commented 1 year ago

Note this will require https://github.com/idaholab/TEAL/pull/70 before tests can pass.

BotrosHanna-INL commented 1 year ago

Hi Paul, You made a comment that this PR is depending on another TEAL PR (idaholab/TEAL/pull/70). Do you want me not to to review this PR until the other TEAL PR is merged?

PaulTalbot-INL commented 1 year ago

Hi Paul, You made a comment that this PR is depending on another TEAL PR (idaholab/TEAL/pull/70). Do you want me not to to review this PR until the other TEAL PR is merged?

You're welcome to review either, I think this PR is done, it just requires the TEAL submod to update before tests will pass on this PR.

PaulTalbot-INL commented 1 year ago

I'm setting up a clean separate install on my machine to see if I can replicate test failures.

EDIT: Nope, it passed on my second installation. Maybe we need to update the TEAL submod of RAVEN first?

moosebuild commented 1 year ago

Job CentOS 8 on d9ad1b7 : invalidated by @dylanjm

TEAL Submodule Updated

dylanjm commented 1 year ago

@PaulTalbot-INL It looks like you're getting a diff on the Windows test. Any idea what may cause that?

PaulTalbot-INL commented 1 year ago
Screenshot 2023-04-11 at 07 51 27

Here's what I've got in the gold file (and what I get on my machine). This agrees well with what's visible on the output of the test run. I'll pin the error at 1e-6 and see what that does for us.