Closed PaulTalbot-INL closed 1 year ago
Updated plots with depreciation:
Note this will require https://github.com/idaholab/TEAL/pull/70 before tests can pass.
Hi Paul, You made a comment that this PR is depending on another TEAL PR (idaholab/TEAL/pull/70). Do you want me not to to review this PR until the other TEAL PR is merged?
Hi Paul, You made a comment that this PR is depending on another TEAL PR (idaholab/TEAL/pull/70). Do you want me not to to review this PR until the other TEAL PR is merged?
You're welcome to review either, I think this PR is done, it just requires the TEAL submod to update before tests will pass on this PR.
I'm setting up a clean separate install on my machine to see if I can replicate test failures.
EDIT: Nope, it passed on my second installation. Maybe we need to update the TEAL submod of RAVEN first?
Job CentOS 8 on d9ad1b7 : invalidated by @dylanjm
TEAL Submodule Updated
@PaulTalbot-INL It looks like you're getting a diff on the Windows test. Any idea what may cause that?
Here's what I've got in the gold file (and what I get on my machine). This agrees well with what's visible on the output of the test run. I'll pin the error at 1e-6 and see what that does for us.
Pull Request Description
What issue does this change request address?
Closes #281
What are the significant changes in functionality due to this change request?
Uses CashFlow "output" options to provide CSV, plots of CashFlow data, such as the following (from test):
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.