idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

Ramp rates #285

Closed PaulTalbot-INL closed 1 year ago

PaulTalbot-INL commented 1 year ago

Pull Request Description

What issue does this change request address?

Closes #88, and contains all of PR #284

What are the significant changes in functionality due to this change request?

Adds ramp rate limiters to produces components (not demands or stores).


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

moosebuild commented 1 year ago

Job CentOS 8 on f19ca74 : invalidated by @dylanjm

Changes made to dependencies

PaulTalbot-INL commented 1 year ago

Screenshot 2023-04-19 at 15 49 40 I did not see this locally before, looking at it more carefully ...

PaulTalbot-INL commented 1 year ago

hm, not sure why this is failing and not getting enough info from the tester to see what it's failing on. I'll have to try and find a windows machine to test on.

PaulTalbot-INL commented 1 year ago

Well, @dylanjm, relative tolerance didn't work before, but seems to work in conjunction with ordered CSV. Good enough for me if it's good enough for you.