Closed yangx789 closed 9 months ago
This looks promising! Two questions:
Thanks again for this PR.
Is the user required to provide colors or do you pick one if they don't? I didn't immediately note that in the code, but I didn't look through it as closely as I should.
@PaulTalbot-INL I believe @yangx789 has it set up so that when we create the outer.xml we loop through the components and give them a default color value. If the user wants specific colors they can go into the outer.xml and modify them.
@PaulTalbot-INL @dylanjm
@yangx789 Thanks! I will try to look at this ASAP; I'm pretty far behind on reviews right now. I do see there's a conflict in the DispatchPlot that needs resolving, though.
We also need a regression test case that covers this modification. Adding color specification to one of the debug-related test cases should cover the testing, perhaps we can add a color request node to https://github.com/idaholab/HERON/blob/devel/tests/integration_tests/mechanics/debug_mode/heron_input.xml?
FYI, there's some issues with the testing machines with a recent library change; they're working on a fix now.
Job CentOS 8 on bfe86c4 : invalidated by @PaulTalbot-INL
job was cancelled, not clear why
Pull Request Description
What issue does this change request address?
261
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.