idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22 stars 36 forks source link

Add component main color from user input #299

Closed yangx789 closed 9 months ago

yangx789 commented 1 year ago

Pull Request Description

What issue does this change request address?

261

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 1 year ago

This looks promising! Two questions:

  1. Is there a test to cover this new feature?
  2. Is the user required to provide colors or do you pick one if they don't? I didn't immediately note that in the code, but I didn't look through it as closely as I should.

Thanks again for this PR.

dylanjm commented 1 year ago

Is the user required to provide colors or do you pick one if they don't? I didn't immediately note that in the code, but I didn't look through it as closely as I should.

@PaulTalbot-INL I believe @yangx789 has it set up so that when we create the outer.xml we loop through the components and give them a default color value. If the user wants specific colors they can go into the outer.xml and modify them.

yangx789 commented 1 year ago

@PaulTalbot-INL @dylanjm

  1. I ran this feature with FORCE use cases 2021 and it works. Any other test we need to add for this feature?
  2. It's an optional feature for users. Component colors will be added automatically in outer.xml from a pre-defined list. They can change color values if they want.
PaulTalbot-INL commented 1 year ago

@yangx789 Thanks! I will try to look at this ASAP; I'm pretty far behind on reviews right now. I do see there's a conflict in the DispatchPlot that needs resolving, though.

PaulTalbot-INL commented 1 year ago

We also need a regression test case that covers this modification. Adding color specification to one of the debug-related test cases should cover the testing, perhaps we can add a color request node to https://github.com/idaholab/HERON/blob/devel/tests/integration_tests/mechanics/debug_mode/heron_input.xml?

PaulTalbot-INL commented 1 year ago

FYI, there's some issues with the testing machines with a recent library change; they're working on a fix now.

moosebuild commented 12 months ago

Job CentOS 8 on bfe86c4 : invalidated by @PaulTalbot-INL

job was cancelled, not clear why