Levelized Cost of Capital

GabrielSoto-INL commented 1 year ago

Pull Request Description

What issue does this change request address?

Closes #300 Linked with https://github.com/idaholab/TEAL/pull/74

What are the significant changes in functionality due to this change request?

HERON now allows <levelized_cost> to be used as the price for a cashflow whose driver is a <variable> (e.g., capacity variable). A new test is added to the mechanics integration tests for calculating levelized cost of capital/capex. This can also be thought of as the break-even cost of capital for a specific component.

If this is is the case, HERON will revert back to the original marginal NPV inner objective function (rather than using the newly introduced levelized objective which is only applied when a user selects a levelized cost associated with resource production/dispatch on a recurring hourly basis).

This was waiting on a small change in TEAL: https://github.com/idaholab/TEAL/pull/74. The change is only for the specific case where the one-time cashflow is also marked for depreciation/amortization: the additional cash flows generated for depreciation/amortization are also carried over as multiplied terms in the NPV search calculation (i.e. they now show up in the denominator).

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild commented 1 year ago

Job CentOS 8 on 35a985f : invalidated by @PaulTalbot-INL

Library updates require rerun

PaulTalbot-INL commented 1 year ago

There are Windows tests failing, but they are timeouts and it's not the same tests failing consistently. Passing this info on to @joshua-cogliati-inl .

In the mean time, required tests have passed, so this can be merged.

idaholab / HERON