The component's total activity

BotrosHanna-INL commented 1 year ago

Pull Request Description

What issue does this change request address?

https://github.com/idaholab/HERON/issues/289

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

BotrosHanna-INL commented 1 year ago

Thank you so much, Dylan for taking the time to review this PR. I modified the dispatch_manager and working now on the template_driver changes.

BotrosHanna-INL commented 1 year ago

@dylanjm I have modified the optimization settings test. It takes less than 300 seconds now.

moosebuild commented 1 year ago

Job CentOS 8 on 1801220 : invalidated by @dylanjm

Not sure what happend. Failure in Example Plugins.

joshua-cogliati-inl commented 1 year ago

Job CentOS 8 on 1801220 : invalidated by @dylanjm

Not sure what happend. Failure in Example Plugins.

ImportError: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /home/civet/miniconda3/envs/raven_libraries/lib/python3.10/site-packages/pandas/_libs/window/aggregations.cpython-310-x86_64-linux-gnu.so

This looks like a conflict between the library that pandas expects and the library that is on the computer. Of hand I am not sure why this is happening in the HERON test on Centos 8, but not on the RAVEN test, which is using the same pandas library. py310h7cbd5c2_1, py310h7cbd5c2_1 https://civet.inl.gov/job/1729335/ versus https://civet.inl.gov/job/1731389/

moosebuild commented 1 year ago

Job CentOS 8 on eabbaaa : invalidated by @joshua-cogliati-inl

used LD_LIBRARY_PATH magic

idaholab / HERON