AnthoneyGriffith commented 11 months ago

Pull Request Description

308

Allows user to specify using Bayesian Optimization for opt runs; furthermore, allows specification of optimizer settings for this method.

The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[ ] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

PaulTalbot-INL commented 6 months ago

@dylanjm what else do we need to look at for this PR?

dylanjm commented 6 months ago

@dylanjm what else do we need to look at for this PR?

I will need to look deeper at it, there is quite a bit of duplicated changes from previous commits.

PaulTalbot-INL commented 4 months ago

Any progress on this? We've got people looking forward to using it!

dylanjm commented 4 months ago

Changes addressed in #344