idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22 stars 36 forks source link

[DEFECT] HERON errors out when type is not defined in optimization settings #314

Closed GabrielSoto-INL closed 10 months ago

GabrielSoto-INL commented 11 months ago

Defect Description

Describe the defect When a user does these specific things:

What did you expect to see happen?

HERON should auto-select the proper optimization type based on the supplies economic metric used for optimization (opt_metric, which defaults to "NPV") then create the outer.xml and inner.xml.

What did you see instead?

Instead I get a KeyError because a dictionary was not keyed correctly.

image

Do you have a suggested fix for the development team?

The dictionary is not being keyed properly because it needs a stats_metric to figure out the correct optimization typing.

Describe how to Reproduce Steps to reproduce the behavior:

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

dylanjm commented 10 months ago

Approved to close via #315