Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22
stars
36
forks
source link
[DEFECT] HERON errors out when type is not defined in optimization settings #314
Describe the defect
When a user does these specific things:
runs HERON in opt mode and
defines an <optimization_settings> node and
does NOT specify a <type> ("min" or "max"), HERON throws an error.
What did you expect to see happen?
HERON should auto-select the proper optimization type based on the supplies economic metric used for optimization (opt_metric, which defaults to "NPV") then create the outer.xml and inner.xml.
What did you see instead?
Instead I get a KeyError because a dictionary was not keyed correctly.
Do you have a suggested fix for the development team?
The dictionary is not being keyed properly because it needs a stats_metric to figure out the correct optimization typing.
Describe how to Reproduce
Steps to reproduce the behavior:
Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.
Platform (please complete the following information):
OS: [e.g. iOS]
Version: [e.g. 22]
Dependencies Installation: [CONDA or PIP]
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.
[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
Defect Description
Describe the defect When a user does these specific things:
opt
mode and<optimization_settings>
node and<type>
("min" or "max"), HERON throws an error.What did you expect to see happen?
HERON should auto-select the proper optimization
type
based on the supplies economic metric used for optimization (opt_metric
, which defaults to "NPV") then create theouter.xml
andinner.xml
.What did you see instead?
Instead I get a
KeyError
because a dictionary was not keyed correctly.Do you have a suggested fix for the development team?
The dictionary is not being keyed properly because it needs a
stats_metric
to figure out the correct optimization typing.Describe how to Reproduce Steps to reproduce the behavior:
Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.
Platform (please complete the following information):
For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.
For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.