idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22 stars 36 forks source link

clean up the validators, now only with FARM_SISO and FARM_MIMO #327

Closed wanghy-anl closed 6 months ago

wanghy-anl commented 6 months ago

Pull Request Description

What issue does this change request address?

No related issues, but to clean up the validators list for FARM 2024 March 31 deliverable

What are the significant changes in functionality due to this change request?
  1. Removed the prototype validators "FARM_Beta" and "FARM_Gamma_LTI"
  2. Renamed the "FARM_Gamma_FMU" as "FARM_SISO"
  3. Renamed the "FARM_Delta_FMU" as "FARM_MIMO"

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

wanghy-anl commented 6 months ago

@PaulTalbot-INL @dylanjm Gents, I would like to clean up the FARM validator list from HERON/src/validators/Factory.py. Now there are only two validators left:

After this clean-up, a lot of repetition in the user manual could be cleared. The capabilities of FARM_Beta and FARM_Gamma_LTI has been merged into FARM_SISO.

Could you review and merge this PR? Thanks, Haoyu

dylanjm commented 6 months ago

@wanghy-anl This has been merged, please submit a submodule update to RAVEN if you need these features in the upcoming release of RAVEN.

wanghy-anl commented 6 months ago

@dylanjm Thank you Dylan. Do you have any plan on updating the HERON submodule in the next weeks? I would like to coordinate the development of FARM based on your schedule, so we can have FARM validator working together with HERON at the same time.