idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

BayesianOpt fix #344

Closed PaulTalbot-INL closed 8 months ago

PaulTalbot-INL commented 8 months ago

Pull Request Description

What issue does this change request address?

Closes #312 Closes #308

What are the significant changes in functionality due to this change request?

Re-implements Anthoney's original PR with only the changes necessary for BayesianOpt.

More work needs to be done to (1) set BayesianOpt as the default optimizer, (2) convert the workshop cases.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 8 months ago

One small change. I'm honestly suprised we don't have to regold all test files since they will default to BO now and I would expect at least some differences in results.

They aren't defaulting to BO yet, just this one test. That would be another step, that I haven't had time to do. This at least makes it available.