Variable initial storage

[PaulTalbot-INL]

---

Pull Request Description

What issue does this change request address?

Closes #345

What are the significant changes in functionality due to this change request?

Allows initial storage level to be a solvable variable when applying periodic conditions. This means that initial_stored will be ignored when periodic conditions are applied.

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• [x] 1. Review all computer code.
• [x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• [x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• [x] 4. Automated Tests should pass.
• [x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
• [x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• [x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• [x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
• [x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

[PaulTalbot-INL]

It looks like the Windows and Linux tests are arriving at different but equivalent solutions, as the diffs are all in the activity and not in the NPV. If I can get some time, I might just gold OS-dependent tests for this.

[PaulTalbot-INL]

I should never rebase, now it's tracking changes from Dylan's PR removing the mult target option. Will try to fix it.

[PaulTalbot-INL]

The files I primarily changed: Source

• src/dispatch/
  • PyomoModelHandler.py
  • PyomoRuleLibrary.py

Tests

• tests/integration_tests/workflows/storage/
  • heron_input.xml
  • analytic.xlsx
  • gold/Sweep_runs_o/sweep.csv
• tests/integration_tests/mechanics/pyomo_options/
  • heron_input.xml
  • analytic.xlsx
  • gold/Sweep_runs_o/sweep.csv

[PaulTalbot-INL]

@dylanjm something magic happened and I'm back down to just the changes for this PR. I also merged in the recent HERON_DATA change, and put the 2-year 21 step CSV that I generated into that central space. This should be ready for review now.