idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
22 stars 36 forks source link

[DEFECT] Running HERON opt using BayesianOpt still creates an outer XML with GradientDescent #350

Closed GabrielSoto-INL closed 2 months ago

GabrielSoto-INL commented 3 months ago

Defect Description

Describe the defect

What did you expect to see happen?

Running HERON optimization using the Bayesian Optimizer.

What did you see instead?

When running HERON in opt mode using the BayesianOpt algorithm, the outer.xml file is written still with the GradientDescent algorithm.

Do you have a suggested fix for the development team?

Quick fix in the template_driver.py since it is looking for "BayesianOptimizer" rather than "BayesianOpt." The regression test should also be updated.

Describe how to Reproduce Steps to reproduce the behavior:

Screenshots and Input Files image

image

Platform (please complete the following information):


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

PaulTalbot-INL commented 2 months ago

Due to the newness of the Bayesian implementation, we may not need to send out a notification. If you want to post a note about it, however, that is fine as well.

Approved to close via #356.