idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

Bayesian Opt input structure fix #356

Closed GabrielSoto-INL closed 7 months ago

GabrielSoto-INL commented 7 months ago

Pull Request Description

What issue does this change request address?

350 , #355

What are the significant changes in functionality due to this change request?
  1. Fixes a previous issue in template_driver.py where if the user requests usage of the BayesianOpt optimization algorithm/strategy, it still writes a GradientDescent node into the outer.xml.

  2. There are modifications to the XML input node under the Cases -> optimization_settings -> algorithm node. The <algorithm> node accepts subnodes rather than a string for either <GradientDescent> or <BayesianOpt>. Each now has algorithm-specific settings that can be modified by the user (all available in the HERON user manual). Default is still <BayesianOpt>.

  3. Some features available in the outer.xml for <GradientDescent> are now able to be modified in the heron input script as described in #355.

  4. Updated some of the scripts for checking XMLs; regolding 'optimization_settings' test to change from Gradient Descent to Bayesian Opt results (larger tolerance, shorter duration)


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 7 months ago

Checklist passes, merging.

We've had enough little changes as well as big fixes like this one, it might be time for a submodule update in RAVEN; @GabrielSoto-INL would you mind opening one?