idaholab / HERON

Holistic Energy Resource Optimization Network (HERON) is a modeling toolset and plugin for RAVEN to accelerate stochastic technoeconomic assessment of the economic viability of various grid-energy system configurations, especially with application to electrical grids and integrated energy systems (IES).
Apache License 2.0
24 stars 38 forks source link

[DEFECT] Debug mode does not work with opt mode #382

Closed GabrielSoto-INL closed 3 months ago

GabrielSoto-INL commented 3 months ago

Defect Description

Describe the defect Nominally, HERON has two options for <mode> in the XML input: sweep or opt. Users can add an additional node to the parent <Case> node to overwrite these two and instead run a shorter debug using the <debug> node. The <mode> node stays in the XML in this case. If the XML script has a combination sweep and debug modes:

<Case>
...
  <mode>sweep</mode>
  <debug/>
...
</Case>

then the debug mode is executed correctly. If the XML script has a combination of opt and debug modes:

<Case>
...
  <mode>opt</mode>
  <debug/>
...
</Case>

then the HERON run fails.

What did you expect to see happen?

Debug mode should work regardless of what <mode> is specified.

What did you see instead?

Two errors depending on whether a user selected GradientDescent or the BayesianOpt algorithms within opt mode. Screenshots are shown below. These are typically errors regarding ElementTree parsing.

Do you have a suggested fix for the development team?

This seems like a template_driver.py problem.

Describe how to Reproduce Steps to reproduce the behavior:

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Error in HERON when using BayesianOpt:

image

Error in HERON when using GradientDescent:

image

Platform (please complete the following information):


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.