idaholab / Malcolm

Malcolm is a powerful, easily deployable network traffic analysis tool suite for full packet capture artifacts (PCAP files), Zeek logs and Suricata alerts.
https://idaholab.github.io/Malcolm/
Other
355 stars 59 forks source link

upstream incompatibility between python regex library 2022.3.15 and dateparser breaks API #84

Closed mmguero closed 2 years ago

mmguero commented 2 years ago

In the last day or two version 2022.3.15 of the python regex library was put out. dateparser depends on that library, but some sort of incompatibility was introduced in this new version.

When calling /mapi/agg, the error bad escape \d at position 7 is now returned instead.

A few stackoverflow threads (1, 2, 3) seem to have come to the same conclusion.

In the meantime I'm going to pin regex to 2022.3.2 in the API docker container.

I don't know if this made it into the v5.2.8 release yesterday. If it did, I'll have to put out a patch fix for it as it renders the API useless.

mmguero commented 2 years ago

Well, crap:

› docker run --rm --entrypoint=/bin/bash malcolmnetsec/api:5.2.8 -c "pip freeze 2>/dev/null | grep regex"
regex==2022.3.15
mmguero commented 2 years ago

Upstream issue information:

dateparser issue: https://github.com/scrapinghub/dateparser/issues/1045

breaking commit in regex library: https://github.com/mrabarnett/mrab-regex/commit/138970bafb3d6fbe0987632ee149c04e8b5acf95

asadurski commented 2 years ago

Hello, this is resolved in dateparser version 1.1.1, released yesterday.

mmguero commented 2 years ago

Hello, this is resolved in dateparser version 1.1.1, released yesterday.

Thanks for the reply and the great library.