Resolve "Improve object printing" - [merged]

[MicahGale]

Merges 41-improve-object-printing -> develop

Objects to be Updated

1. [x] cells
2. [x] cell_data_control
3. [x] cell
4. [x] materials
5. [x] material
6. [x] ~mcnp_card~
7. [x] mcnp_problem
8. [x] surfaces
9. [x] particle
10. [x] importance
11. [x] isotope
12. [x] material_component
13. [x] mode
14. [x] thermal_scattering
15. [x] transform
16. [x] volume
17. [x] block_type
18. [x] Card
19. [x] Jump
20. [x] Comment
21. [x] Read Card
22. [x] surface
23. [x] Element

Closes #41

[MicahGale]

unassigned @MicahGale

[MicahGale]

marked the checklist item volume as completed

[MicahGale]

marked the checklist item importance as completed

[MicahGale]

marked the checklist item cells as completed

[MicahGale]

marked the checklist item materials as completed

[MicahGale]

marked the checklist item surfaces as completed

[MicahGale]

added 2 commits

• 6157f879 - Removed useless input file
• 4a2874a7 - Updated printing for all numbered object collections

Compare with previous version

[MicahGale]

marked the checklist item cell_data_control as completed

[MicahGale]

added 1 commit

• e8a083d4 - Updated mcnpy str

Compare with previous version

[MicahGale]

marked the checklist item particle as completed

[MicahGale]

marked the checklist item mode as completed

[MicahGale]

marked the checklist item Jump as completed

[MicahGale]

marked the checklist item Card as completed

[MicahGale]

marked the checklist item Comment as completed

[MicahGale]

added 1 commit

• 74dfba27 - Updated some string outputs

Compare with previous version

[MicahGale]

added 4 commits

• 74dfba27...8e0e6ad6 - 3 commits from branch develop
• 2387dc31 - Merge branch 'develop' into 41-improve-object-printing

Compare with previous version

[MicahGale]

added 1 commit

• ef50ab78 - Updated string tests, and fixed a few bugs

Compare with previous version

[MicahGale]

marked the checklist item Read Card as completed

[MicahGale]

marked the checklist item block_type as completed

[MicahGale]

added 1 commit

• b89ee3a7 - Updated cell printing

Compare with previous version

[MicahGale]

marked the checklist item cell as completed

[MicahGale]

added 3 commits

• 55fde3b7 - Added the WHOLE periodic table
• c16f7794 - Слава Україні
• 1006eda0 - Revert "Слава Україні"

Compare with previous version

[MicahGale]

added 3 commits

• 6d4b2c7c - Complemeted element API
• fba5a40e - Updated how material is printed
• e9de26f8 - Fixed bug with variable shadowing

Compare with previous version

[MicahGale]

marked the checklist item material as completed

[MicahGale]

marked the checklist item mcnp_card as completed

[MicahGale]

marked the checklist item Element as completed

[MicahGale]

marked the checklist item isotope as completed

[MicahGale]

added 2 commits

• 6cd73240 - Made element printable
• c1b312de - Improved isotope printing

Compare with previous version

[MicahGale]

added 1 commit

• b650be8a - Fixed bugs with isotope string conversion

Compare with previous version

[MicahGale]

marked the checklist item material_component as completed

[MicahGale]

marked the checklist item thermal_scattering as completed

[MicahGale]

marked the checklist item surface as completed

[MicahGale]

added 3 commits

• 93e3ddb7 - Add thermal scattering string formatter
• 4d3c7e80 - Added printing for surface
• 70099f2f - Updated string formatting for transform

Compare with previous version

[MicahGale]

marked the checklist item transform as completed

[MicahGale]

marked the checklist item mcnp_problem as completed

[MicahGale]

added 2 commits

• 4057a1e2 - Implemented element testing
• 9f6a4c7b - Fixed bug with static methods

Compare with previous version

[MicahGale]

added 1 commit

• 4bfe2aa0 - Made material test into multiple classes, and tested strings

Compare with previous version

[MicahGale]

added 1 commit

• d1a9e23d - Added thermal scattering testing and fixed bug

Compare with previous version

[MicahGale]

added 7 commits

• bdf963a8 - Did print testing for read card
• f4ce8918 - Added various print testing
• b9d7df0a - Cleaned some repr bugs
• 0dd24267 - Removed unused next function
• ae6a4a62 - Tested cells represantation
• 38ec79a7 - Made elements hashable and equalable
• c6ae67f0 - Tested particle printing

Compare with previous version

[MicahGale]

marked this merge request as ready

[MicahGale]

requested review from @tjlaboss

[MicahGale]

I think the new Element class will need the most amount of review.

[MicahGale]

In GitLab by @tjlaboss on Oct 25, 2022, 14:12

Commented on mcnpy/data_cards/element.py line 293

Does capitalization matter? If so, correct "Rhenium".

[MicahGale]

In GitLab by @tjlaboss on Oct 25, 2022, 14:12

Commented on mcnpy/data_cards/isotope.py line 86

Representing with the .library syntax might be confusing.

Also suggest aligning with:

f"{self._ZAID:>6}"
# or
f"{self.element.symbol:>3}-{self.A:<3}"

[MicahGale]

In GitLab by @tjlaboss on Oct 25, 2022, 14:12

Commented on tests/test_material.py line 75

See above. Basically I think this should either stick with ZAID.suffix, or else distinguish the library some other way.

Maybe printed as

  H-1  (80c) 0.5
  O-16 (80c) 0.5

[MicahGale]

In GitLab by @tjlaboss on Oct 25, 2022, 14:12

There is one typo to fix before merging.

I have opinions on the Isotope printing that are optional.

[MicahGale]

good catch. I am trying for everything to lower case.

[MicahGale]

Oh I do like your format for printing it. I think I'll implement that. The library information is till present and usable but not obnoxious.

[MicahGale]

changed this line in version 16 of the diff

[MicahGale]

changed this line in version 16 of the diff