Complete syntax parsing rework to preserve user formatting. - [merged]

[MicahGale]

Merges 48-add-support-for-keeping-comments -> alpha-test

Tests to add:

1. [ ] test tab expansion.
2. [ ] Test SC and FC tally comments
3. [ ] Ensure comments get placed with following object.
4. [ ] Clear out all TODO comments.
5. [ ] Clean up code and refactor.
6. [ ] Update all documentation.
7. [ ] Can I delete allowed_keywords?

[MicahGale]

added 4 commits

• 0a997e0d - Fixed bug where is_negatable isn't being updated
• 7bcf7021 - Fixed bug to try to format a None ValueNode
• 5ff44398 - Fixed tokens being broken by C/Z
• 18c4353b - Fixed surface type not being forced to upper case for parsing

Compare with previous version

[MicahGale]

In GitLab by @tjlaboss on Feb 22, 2023, 09:21

Commented on mcnpy/input_parser/syntax_node.py line 179

In this regex, + or - is required. It doesn't match, e.g., '1.9e3'.

[MicahGale]

added 3 commits

• 6400df02 - Updated number token RE to allow non zero starting number
• f794cca6 - Created system for a float to be formatted as an int
• 14e855ef - updated formatting test to match in and out precision properly

Compare with previous version

[MicahGale]

Oh good catch. Are you reviewing the formatter right now?

[MicahGale]

changed this line in version 103 of the diff

[MicahGale]

added 1 commit

• 4beb5d9d - Made +/- optional after the e in scientific notation

Compare with previous version

[MicahGale]

In GitLab by @tjlaboss on Feb 22, 2023, 10:10

Commented on mcnpy/input_parser/syntax_node.py line 179

No

[MicahGale]

In GitLab by @tjlaboss on Feb 22, 2023, 10:10

resolved all threads

[MicahGale]

This commit actually broke things. It was meant to find fortran floats too. I need to make a branching RE.... sigh.

[MicahGale]

added 2 commits

• 5b102b7f - Updated RE to match real Scientific OR fortran scientific
• 1d2070ef - Prevented excessive zero padding floats to ints

Compare with previous version

[MicahGale]

added 12 commits

• 93848e7e - Allowed spaces around parens
• fd9018ee - removed old print
• 827167d2 - Made ValueNode a negetable float
• 2112d6d3 - Updated compare function for ValueNode
• e03b5f87 - Updated material number bug
• 57086fbd - Made material use is negetable float for ValueNode
• dc46a4f6 - Fixed bugs with material number
• 935a5f5b - Fixed thermal scattering number
• e7a4ab68 - Updated thermal scattering format for mcnp
• 70e32c9a - Fixed material isotope init test
• df52dd21 - Revert "Fixed material isotope init test"
• d4e64ce8 - Made system for the material component to accept raw float

Compare with previous version

[MicahGale]

added 11 commits

• 08b74822 - Corrected thermal scatter format test to maintain user formatting
• c33d2054 - Updated material reprt test to include value node as more info
• 6a94e5a2 - Updated material_component to use ValueNode wrapper prop
• 6c17fd6d - Updated material repr to show value Nodes
• dbeeb04e - Made isotopesNode iterable
• 73f3f789 - Fixed bug with negatable float state
• 64321e82 - Updated fill universe_input and lattice to use input
• 2db6e0bb - Created system for padding nodes to chunk by new line
• 0b88682e - Made valueNode append all remaining padding
• dcd1b854 - Updated formatting test to preserve user input
• e12536a1 - Updated universe to keep seperate variable for universes list

Compare with previous version

[MicahGale]

added 6 commits

• 690b604e - Updated mat test to use parameter property
• 3d5cbff8 - Added debugfile to allow simpler debug without subclass cascade
• d975750f - Made ZAID phrase parsing more robust
• cf144b06 - Fixed bug with library parameter breaking parameter parsing
• 56dfc1ce - Adding some SLY meta tasks
• 86f3834a - Fixed bug with with messing with problem before getting linked to it

Compare with previous version

[MicahGale]

added 1 commit

• 08d80aeb - Avoided SLY bug from geometry shortcuts getting into dead end

Compare with previous version

[MicahGale]

added 2 commits

• bef9f417 - Fixed node based parsing for Importance
• 31f0018a - Fixed importance to use ValueNodes properly

Compare with previous version

[MicahGale]

added 1 commit

• 345b9f0c - Removed double adding in of padding

Compare with previous version

[MicahGale]

added 7 commits

• 345b9f0c...e5d24d04 - 6 commits from branch develop
• d9eda2be - Merge branch 'develop' into 48-add-support-for-keeping-comments

Compare with previous version

[MicahGale]

added 5 commits

• 5050082d - Updated particle token RE to be robust and handle #2004
• fc8de225 - Made mode specific parser
• a29f485c - Removed old test
• 0b127461 - Fixed bug with returning tokens
• da7fa622 - Updated mode to use Syntax Tree

Compare with previous version

[MicahGale]

added 3 commits

• 1dcbcd45 - Made method to remove items from ListNode
• 0e17f5cb - Cleaned up default classifier node
• e75d3d92 - Implemented update values for mode

Compare with previous version

[MicahGale]

added 2 commits

• 8c1848e1 - Made geometry tree nesting printing easier to read
• 953a9dd4 - Fixed how Geometry tree crawls binary tree for information

Compare with previous version

[MicahGale]

added 1 commit

• f98025e8 - Made update pointers use valueNode machinery

Compare with previous version

[MicahGale]

added 4 commits

• 6d961f6c - Added guard against double adding surfaces
• 279b86ba - Changed default universe to 0
• c93cc1a8 - Fixed parsing isssues with init of Universe
• 28265a44 - Made Universe Input more compatible with ValueNodes

Compare with previous version

[MicahGale]

added 2 commits

• 9d6cf78a - Updated bad parameter parsing testing to use Syntax Tree
• 49c67ba9 - Made Shortcut expansion compatible with geometry call

Compare with previous version

[MicahGale]

added 1 commit

• d1dc5076 - Started context dependent lexers

Compare with previous version

[MicahGale]

added 1 commit

• ab0268f7 - Created context dependent Lexer

Compare with previous version

[MicahGale]

added 3 commits

• bbdea50e - Added support for colons in fill inputs
• 6d1548ee - Converted some universe tests over to using syntax trees
• 2a690330 - Did broken implementation of syntax tree in Fill

Compare with previous version

[MicahGale]

added 8 commits

• 2a690330...328b0ec4 - 6 commits from branch develop
• 3c7bcd0a - Merge branch 'develop' into 48-add-support-for-keeping-comments
• 0046b5a6 - Removed license based on TD input

Compare with previous version

[MicahGale]

added 2 commits

• 70443267 - Started update of Fill to use Syntax Tree
• cd329461 - Made list node accept slices

Compare with previous version

[MicahGale]

added 3 commits

• b6cff39f - Removed mutated tests
• 625dd589 - Worked on full implementing fil syntax tree parsing
• f44d8d0c - Updated test to use syntax tree fixture. Probably not do it.

Compare with previous version

[MicahGale]

added 1 commit

• 6b3d073c - Updated most tests to use new Syntax Tree, and used SetUp for redundant code

Compare with previous version

[MicahGale]

added 3 commits

• bcde0400 - Updated old_universe_numbers tests
• 3f0bfa12 - fixed fill init bugs
• 31e7cb73 - Switched to numpy arrays storing only ints

Compare with previous version

[MicahGale]

added 2 commits

• f6f26d44 - Updated parser with option to ignore 1 or 0
• 6faa299e - Fixed bug with lefover from valueNode to Int

Compare with previous version

[MicahGale]

added 2 commits

• f3995d81 - updated fill tests for proper fixture
• 0e920f47 - Fixed bug in classifier format

Compare with previous version

[MicahGale]

added 1 commit

• 7b09955a - Started fixing Fill init with transforms

Compare with previous version

[MicahGale]

added 4 commits

• ca92b542 - Made ListNode slice return instance of self
• c049222b - Avoided recursive ListNodes with transform nesting
• 94657f23 - Made fill transform init use ListNode features
• 9ebb9e00 - Fixed the stupid off by one error bug

Compare with previous version

[MicahGale]

added 3 commits

• 73d857f7 - Made old_universe_number a ValueNode property
• 12ff6b25 - Fixed how modifier is accessed in FILL and TRANSFORM
• db4fd4af - Fixed Data parser to handle * being a particle classifier

Compare with previous version

[MicahGale]

added 5 commits

• a024cf8a - Fixed broken input breaking test
• 583e870b - Fixed fill old_transform_number to value node
• 22c6566f - Made fill parsing more fault tolerant
• 6bd1ce6e - Updated lattice to use syntax tree parsing
• d8eca2de - Fixed minor bugs with test

Compare with previous version

[MicahGale]

added 3 commits

• 2b4f0e20 - Made it so shortcut tokens don't expect ending space
• 7fdcbcbd - Avoided having paddingNode at top level
• 01a8df09 - Fixed test typo

Compare with previous version

[MicahGale]

added 1 commit

• a7d3835d - removed words

Compare with previous version

[MicahGale]

added 4 commits

• 005a1c6b - Finished converting lattice to syntax tree parsing
• 7442ed56 - Made convert to int go off string to catch bad float rouding
• 00dcba1a - Made universe old_numbers consistent
• c2af0d0a - Updated universe init test fixtures

Compare with previous version

[MicahGale]

added 2 commits

• b0f811ee - updated all universe tests to use new universe test fixture
• d2075e86 - Updated universe str and format_for_mcnp

Compare with previous version

[MicahGale]

added 1 commit

• 6e0846d9 - Updated test for preserving cases

Compare with previous version

[MicahGale]

added 75 commits

• 6e0846d9...f64635a2 - 74 commits from branch develop
• c6f28d19 - Merge branch 'develop' into 48-add-support-for-keeping-comments

Compare with previous version

[MicahGale]

added 2 commits

• 4b788d81 - Cleaned up after merge
• edf3e5ba - Removed typo bug in var name

Compare with previous version

[MicahGale]

added 4 commits

• 0b2c70e9 - Updated test to not use words
• d798b6f5 - Created jank lexer system to properly tokenize shortcuts
• c654d528 - Fixed data structure return for ReadInput
• 6294e5f0 - Fixed bug with read input

Compare with previous version

[MicahGale]

added 2 commits

• b4d09254 - Fixed test to not look for comments
• 0bdec00c - Updated state machine to not flush comment only input at block start

Compare with previous version

[MicahGale]

added 1 commit

• db94fbc4 - Updated repr test for read input

Compare with previous version

[MicahGale]

added 4 commits

• 01d3620e - Updated test to use syntax trees
• dd5ea0af - Improved data card particles
• 7fe644da - Updated classifier to accepted F tally as a particle -_-
• 474794b8 - Made text not need any digits

Compare with previous version

[MicahGale]

added 2 commits

• 66e95e1a - Updated data parsing test fixture with new data input init
• 2c402b50 - Fixed bugs with revamped data type enforcement

Compare with previous version

[MicahGale]

added 1 commit

• 6a51950a - Updated syntax testing to use syntax tree stuff

Compare with previous version