search

idaholab / MontePy

MontePy is the most user friendly Python library (API) to read, edit, and write MCNP input files.
https://www.montepy.org/
MIT License
30 stars 6 forks source link

Feature: Parse data libraries by true library and temperature. #55

Closed MicahGale closed 7 months ago

MicahGale commented 2 years ago

Make so that it can be understand that 80c is ENDF/B-VII.1 at room temp. This way you can either change libraries and preserve temperature or preserve temperature and change libraries.

MicahGale commented 2 years ago

created branch 14-feature-parse-data-libraries-by-true-library-and-temperature to address this issue

MicahGale commented 2 years ago

@BrennaCarbno when you can create a draft merge request for this based off of develop, and tag this issue (#14).

To summarize:

  1. MCNPy should know:
    1. The nuclear data library the data is from (e.g., ENDF/B-VIII.0),
    2. The temperature of the data,
    3. and the type of data (e.g., continuous energy neutron cross-sections, versus discrete-energy Photoatomic data, etc.)
  2. This will require new object classes, so let's make an object model.
  3. We may want to change how the Material object stores data to be more use friendly, but that's not essential for this.

When you have a good idea of how you want to tackle this let's have a review meeting with (@BrennaCarbno, @tjlaboss, and @MicahGale).

MicahGale commented 2 years ago

Remember: users can modify their XSDIR and change their suffixes.

MicahGale commented 2 years ago

From meeting next actions:

  1. Parse whole core model with wrapper script
  2. Add support for XSDIR maybe? (concerned about EC restrictions on format)
  3. Add xsdir parser like: mcnpy.read_xsdir
  4. Map xsdir to materials.

Default behavior without XSDIR file? Default to LANL document, and raise a warning.

MicahGale commented 1 year ago

Also should implement #71 concurrently.

MicahGale commented 1 year ago

In GitLab by @tjlaboss on Feb 21, 2023, 15:20

  1. LANL has made all that stuff public.

https://github.com/nucleardata/DataListing https://nucleardata.lanl.gov/files/la-ur-08-1999.pdf

MicahGale commented 1 year ago

Ok yeah so definitely no EC concerns. But I think reading XSDIR is the best idea.

Side: why did they bake Jupyter into that tool?

MicahGale commented 1 year ago

WWWhhhhyyyy?

MicahGale commented 1 year ago

In GitLab by @tjlaboss on Feb 21, 2023, 16:28

LANL Did Something
MicahGale commented 1 year ago

marked this issue as related to #71

MicahGale commented 7 months ago

Redundant with #21