Remove duplicate surfaces broke geometry logic update, and made two surface numbers identical

idaholab / MontePy

MontePy is the most user friendly Python library (API) to read, edit, and write MCNP input files.

https://www.montepy.org/

MIT License

32 stars 6 forks source link

Remove duplicate surfaces broke geometry logic update, and made two surface numbers identical #57

Closed MicahGale closed 10 months ago

MicahGale commented 2 years ago

See: https://hpcgitlab.hpc.inl.gov/galemica/afc-oa-171a/-/tags/broke_mcnpy_remove_dups

The geometry logic: -61597 61825 -85143 became: -61597 61825 -61825

MicahGale commented 2 years ago

This really should be resolved by: #12.

MicahGale commented 2 years ago

This would require lots of work. May be better to just interface with OpenMC and use their implementation.

MicahGale commented 1 year ago

I'm adding this to the scope of !73 to test and verify it's good.

MicahGale commented 11 months ago

I think this bug is so intrinsic to version 0.1.0 and with release 0.2.0/ !73 this bug will be extremely difficult to reproduce. Also due to the new approach it should realistically not happen as long as the unit tests for the geometry system pass.

Due to this I am closing this issue.