Open MicahGale opened 2 years ago
In GitLab by @tjlaboss on Jul 21, 2022, 14:50
Opinion: Type enforcement/coercion should not be done here. Coercion can still be used on a case-by-case basis, not part of a broad function annotation and type hinting update.
If there is a function annotation style guide for mcnpy, I can probably tackle the implementation between other tasks.
So are you in favor of just using typing notations as purely a developer/ user assistant?
Any good resources for developing a style guide?
marked the checklist item @MicahGale started a discussion: as completed
https://github.com/Instagram/MonkeyType This tool that @tjlaboss found could help with automating most of the work.
Oh right this issue is a little different now since the introduction of make_prop_pointer
and make_prop_value_node
has removed most of the property boiler plate type enforcement.
I think we are now at a stage that using this as a type enforcement scheme is unnecessary, but is just syntax sugar to help make it more usable for the end user.
The following discussion from !37 should be addressed:
[x] @MicahGale started a discussion:
Tasks: