idaholab / TEAL

TEAL is a financial performance calculator plugin for the RAVEN code, framework, resolving around the computation of Net Present Value and associated financial metrics.
Apache License 2.0
9 stars 21 forks source link

[DEFECT] Fix Numpy Future Warning #52

Closed dylanjm closed 2 years ago

dylanjm commented 2 years ago

Defect Description

Describe the defect

What did you expect to see happen?

I am seeing this warning when running heron:

/scratch/mcdodyla/TEAL/src/main.py:411: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
  projCf[decomissionMask] += lifeCf[-1] * taxMult * np.power(inflRate, -1*years[decomissionMask])

which appears to be talking about this portion of code:

  if operatingYears[-1] < years[-1]:
    decomissionMask[0] = np.hstack((decomissionMask[0],np.atleast_1d(operatingYears[-1]+1)))
  if not pyomoVar:
    projCf[decomissionMask] += lifeCf[-1] * taxMult * np.power(inflRate, -1*years[decomissionMask])
  else:
    for i in range(len(decomissionMask[0])):
      projCf[decomissionMask[0][i]] += lifeCf[-1] * taxMult * np.power(inflRate, -1*years[decomissionMask[0][I]])

We should fix this before it breaks or gives us wrong answers.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

dylanjm commented 2 years ago

Approved to close vis #61