idaholab / TEAL

TEAL is a financial performance calculator plugin for the RAVEN code, framework, resolving around the computation of Net Present Value and associated financial metrics.
Apache License 2.0
9 stars 21 forks source link

Changed handling of recurring cashflows to better suit object oriented #59

Closed AnthoneyGriffith closed 2 years ago

AnthoneyGriffith commented 2 years ago

Pull Request Description

What issue does this change request address?

58

What are the significant changes in functionality due to this change request?

When defining cashflows outside of TEAL, calculateYearlyCashflow/calculateIntraYearlyCashflow over the project lifetimes. TEAL will now consider a unique cashflow expression for each year of the project life.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

PaulTalbot-INL commented 2 years ago

@dylanjm do you have time to double-check this fix? I want to make sure we didn't overlook something.

dylanjm commented 2 years ago

@dylanjm do you have time to double-check this fix? I want to make sure we didn't overlook something.

@PaulTalbot-INL Yes, I can check it today.

PaulTalbot-INL commented 2 years ago

@dylanjm @AnthoneyGriffith checking on this PR, any additional changes or reviews needed?