Renaming depreciation cash flows

PaulTalbot-INL commented 1 year ago

Pull Request Description

Moves from string parsing to a specific flag to check which depreciation cash flows are tax credits and which are value losses.

Also converts old poorly-chosen names for depreciation cashflows from depreciate and amortize to:

depreciation for component value loss (negative cash flow)
depreciation_tax_credit for tax credit associated with MACRS depreciation/amortization (positive cash flow).

The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass.
[x] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[x] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

PaulTalbot-INL commented 1 year ago

Note that when this closes, the associated HERON issue can also be closed; however I don't see a way to automatically link them.

PaulTalbot-INL commented 1 year ago

@worseliz I want to make sure you get a chance to see this as FYI