idaholab / TEAL

TEAL is a financial performance calculator plugin for the RAVEN code, framework, resolving around the computation of Net Present Value and associated financial metrics.
Apache License 2.0
9 stars 21 forks source link

[DEFECT] CashFlowPlot list index out of range error when too many components are selected #82

Closed GabrielSoto-INL closed 5 months ago

GabrielSoto-INL commented 5 months ago

Defect Description

Describe the defect

What did you expect to see happen?

When generating cashflow plots for a list of components longer than the colormap list in the code, TEAL errors out.

What did you see instead?

The list of components is longer than the given colorLib. This is from a HERON debug run of the wind workshop case.

Exception has occurred: IndexError
list index out of range
  File "C:\Users\sotogj\projects\TEAL\src\CashFlowPlot.py", line 124, in run
    _cmap = plt.get_cmap(colorLib[i])
  File "C:\Users\sotogj\projects\raven\ravenframework\OutStreams\PlotEntity.py", line 103, in addOutput
    self._plotter.run()
  File "C:\Users\sotogj\projects\raven\ravenframework\Steps\IOStep.py", line 264, in _localTakeAstepRun
    output.addOutput()
  File "C:\Users\sotogj\projects\raven\ravenframework\Steps\Step.py", line 317, in takeAstep
    self._localTakeAstepRun(inDictionary)
  File "C:\Users\sotogj\projects\raven\ravenframework\Simulation.py", line 834, in executeStep
    stepInstance.takeAstep(stepInputDict)
  File "C:\Users\sotogj\projects\raven\ravenframework\Simulation.py", line 901, in run
    self.executeStep(stepInputDict, stepInstance)
  File "C:\Users\sotogj\projects\raven\ravenframework\Driver.py", line 160, in raven
    simulation.run()
  File "C:\Users\sotogj\projects\raven\ravenframework\Driver.py", line 207, in main
    raven()
  File "C:\Users\sotogj\projects\raven\raven_framework.py", line 25, in <module>
    sys.exit(main(True))
IndexError: list index out of range
Do you have a suggested fix for the development team?

If there are more components than colormaps, TEAL should repeat the sequence and maybe add different hatching patterns for the repeated sequences.

Describe how to Reproduce Steps to reproduce the behavior:

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.


For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

PaulTalbot-INL commented 5 months ago

Approved to close via #84.