Fix tests breaking with parallel and recover flags

idaholab / TMAP8

Tritium Migration Analysis Program, Version 8

https://mooseframework.inl.gov/TMAP8/

GNU Lesser General Public License v2.1

14 stars 17 forks source link

Fix tests breaking with parallel and recover flags #122

Closed chaibhave closed 4 months ago

chaibhave commented 4 months ago

refs #112

Reason

TMAP8 tests are failing with -p 2 --n-threads 2.

Design

Using LU in tests helps prevent exodiff errors.
The Interface Sorption Sievert test uses a mesh BreakMeshByBlockGenerator, which is currently incompatible with distributed meshes. This test should only run on replicated meshes.
Added CSVDiff and Python script tests for 1-fa.

Impact

Fixing broken tests will build confidence in TMAP8 results with larger problems that require parallel and recovery features.

moosebuild commented 4 months ago

Job Documentation on 7c274aa wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 4 months ago

Job Coverage on 7c274aa wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

chaibhave commented 4 months ago

These tests need further improvements (which will be dealt with in the PR for #123 ), but for now this fixes the tests that were breaking in parallel runs, distributed meshes or with the recovery options.

chaibhave commented 4 months ago

@cticenhour can you also review this and make sure if it's sufficient to close #112 ?