idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
14 stars 17 forks source link

Add ver-1ja to TMAP8 (decay) #146

Closed simopier closed 2 months ago

simopier commented 2 months ago

Add ver-1ja to TMAP8 as verification case Add tests and gold file Add python script for analysis and plotting Add documentation for case ver-1ja

(Ref. #145)

moosebuild commented 2 months ago

Job Documentation on a86c370 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 2 months ago

Job Coverage on a86c370 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

cticenhour commented 2 months ago

@chaibhave Before I review this - are all of your comments addressed? If so, please resolve as applicable.

chaibhave commented 2 months ago

@chaibhave Before I review this - are all of your comments addressed? If so, please resolve as applicable.

@cticenhour It all looks to me, but I don't have the ability to resolve the comments

cticenhour commented 2 months ago

I forgot that point - I will resolve. Thanks! Just wanted to double-check.

simopier commented 2 months ago

The csv file is only slightly affected by the executioner block clean up. The changes are so small that the documentation figure is identical (git did not see a difference), which is why it's not updated in the last commit.