idaholab / TMAP8

Tritium Migration Analysis Program, Version 8

https://mooseframework.inl.gov/TMAP8/

GNU Lesser General Public License v2.1

15 stars 19 forks source link

Documentation for validation cases 1a-1d #18

Closed singhgp4321 closed 2 years ago

singhgp4321 commented 2 years ago

12

Add documentation for case 1a, 1b, 1c and 1d.

lindsayad commented 2 years ago

@singhgp4321 thank you so much for adding these contributions. Can you make sure that your commit contains an issue reference? E.g. you can run git commit --amend and make sure somewhere in the commit message you put "#12"

singhgp4321 commented 2 years ago

@lindsayad Issue reference added.

moosebuild commented 2 years ago

Job Documentation on 8900cea wanted to post the following:

View the site here

This comment will be updated on new commits.

lindsayad commented 2 years ago

The val-1c test result looked it changed a lot ... but you didn't change anything 🤔 I don't know what's going on there. Will have to investigate more. It looks like you deleted the val-1d.md file. Was that intentional? With the changes/additions made to the val-1b.i input we will have to regold that.

singhgp4321 commented 2 years ago

val-1d.md was mistakenly deleted, now it's back. Still need to add a couple of comparison plots in that md file; working on it . . . I'll look into val-1c and will regold 1b.

lindsayad commented 2 years ago

if you want some help looking into val-1c let me know

singhgp4321 commented 2 years ago

val-1b regolded
documentation added to the val-1d.md including the comparison plots
val-1c_out.e was diffing probably because of my mistake; it should pass now

For some reason, the comparison of val-1d results with the analytical solution does not look impressive (val-1d_comparison_diffusion.png). I suspect that some parameter used in the analytical solution (see comparison_val-1d.py) is not what it should be.

lindsayad commented 2 years ago

This is really nice documentation @singhgp4321. I'm super impressed. Probably better than any doc I've ever made 😆 We should try and look into the 1d discrepancies, but that is another task. Thank you!!

singhgp4321 commented 2 years ago

Haha 😆 You're welcome! Let's touch base sometime next week for implementing the other validation cases. You had mentioned that probably we'll need to develop kernels for the other cases.

lindsayad commented 2 years ago

Sounds good! Just let me know when you want to meetup. I will be out of town on Monday but should be available on other days

On Fri, May 13, 2022 at 8:25 AM Gyanender Singh @.***> wrote:

Haha 😆 You're welcome! Let's touch base sometime next week for implementing the other validation cases. You had mentioned that probably we'll need to develop kernels for the other cases.

— Reply to this email directly, view it on GitHub https://github.com/idaholab/TMAP8/pull/18#issuecomment-1126175504, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOGA4CP4NQJF66AEZ6TCMTVJZX6LANCNFSM5RMH25FQ . You are receiving this because you modified the open/close state.Message ID: @.***>