search

idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 19 forks source link

Adding val-1e case #21

Closed singhgp4321 closed 1 year ago

singhgp4321 commented 2 years ago

12

singhgp4321 commented 2 years ago

@lindsayad @cticenhour For some reason the concentration profile does not evolve with time. The solution is incorrect. Do you have any insight?

lindsayad commented 2 years ago

@singhgp4321 I'm going to be on vacation for the next two and a half weeks. There's a good chance I won't be able to look at this until I'm back. Sorry for the delay!

lindsayad commented 2 years ago

@singhgp4321 sorry it took me so long to get around to this. Please see the commit I just pushed. I think things look pretty good now

moosebuild commented 2 years ago

Job Documentation on 05732ba wanted to post the following:

View the site here

This comment will be updated on new commits.

singhgp4321 commented 2 years ago

@cticenhour

singhgp4321 commented 1 year ago

@cticenhour @lindsayad Tests with threads and parallel are failing due to csvdiff. I've tried tightening the nl_rel_tol but that does not work.

lindsayad commented 1 year ago

@cticenhour from the call today it sounded like you were looking into this. If I understood wrong, I can take a look tomorrow

cticenhour commented 1 year ago

I was able to duplicate the issue on moosebuild, and think I have some things to try tomorrow. Might reach out if I get stuck.

lindsayad commented 1 year ago

@singhgp4321 why did you choose the point that you did for the postprocessor?

lindsayad commented 1 year ago

It's possible that the PointValue postprocessor is not robust when the length scale is as small as it is in this test. For instance I had to make sure to match IDs instead of performing geometric topology based matching with Exodiff because it complained that the element centroids were so close together there were multiple matches. Anyway with my added commit, serial, parallel, and threads are passing for me locally. We'll see what CIVET says

singhgp4321 commented 1 year ago

Sorry for this delayed response.

@lindsayad That particular point was chosen based on the documentation for TMAP4 or TMAP7: they used that point for verification and I tried to be consistent with them. Thanks for fixing the issue.