idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 19 forks source link

Create an interface kernel to impose Sievert's law: #51

Closed simopier closed 1 year ago

simopier commented 1 year ago

(Close #50)

simopier commented 1 year ago

Hmm, Clang format check fails, but applying the patch does not change any files:

(moose) fn654432:TMAP8 simopa$ git clang-format 50a0ed49c355e4367ca23357150231f92ed78b54
clang-format did not modify any files

@cticenhour ?

moosebuild commented 1 year ago

Job Documentation on 66537a7 wanted to post the following:

View the site here

This comment will be updated on new commits.

lindsayad commented 1 year ago

How general is this? Would the scalar transport module be a good fit, or is here better?

simopier commented 1 year ago

How general is this? Would the scalar transport module be a good fit, or is here better?

Good question. I figured that since I implemented it specifically for Sievert's Law with an Arrhenius solubility, it would be specific to TMAP8 needs, but maybe that was a poor judgement call on my end. Any suggestion?

lindsayad commented 1 year ago

I guess I think of Arrhenius as being pretty general. I remember learning about Arrhenius rates back in gen chem eons ago

lindsayad commented 1 year ago

I leave it up to you @simopier. I love the contribution, so I'll be delighted to take it here or in the STM in MOOSE

moosebuild commented 1 year ago

Job Precheck on 45fdb13 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/51/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 89e66fe63a0d24640a27208d6098e2c54f799922

cticenhour commented 1 year ago

Thanks again @simopier! If we ever want to move this into the scalar transport module later, we can do that and preserve this history.