idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 18 forks source link

Some issues in verification case ver-1g #84

Closed chaibhave closed 5 months ago

chaibhave commented 7 months ago

Bug Description

There's a few minor issues with this verification case:

  1. Wrong csv file name for the same concentration case in the Python script on line 30.
  2. The different concentration MOOSE input file uses the wrong initial value of c_b, which is why the numerical solution never reaches the analytical prediction. Initial value from analytical model is 1.215e-4, input file uses 1.225e-4
  3. The error added to concB_o in the Python script for the different concentration case is unnecessary. The same error in the equal concentration case prevents a divide by zero error. Worth checking if the analytical solution applies if the correct values create a divide by zero error.

Impact

Fixing these bugs makes the verification test script work properly, and removes the apparent error between the numerical solution and analytical model.

chaibhave commented 7 months ago

@simopier @cticenhour

RemDelaporteMathurin commented 7 months ago

Good catch @ChaitanyaBhave-e ! How come these weren't caught by the CI?

chaibhave commented 7 months ago

@RemDelaporteMathurin I think it's because the Python scripts aren't currently set up to run as tests. They're set up to be manually run by the users. Rendering the figures in real time for the documentation and having a test that checks for the RMSE of the analytical solution vs MOOSE solution should fix this issue in the future.

chaibhave commented 7 months ago

Regarding point three in my issue, I realized that the correct analytical solution for equal concentration is already provided in the documentation for this verification. The Python script uses the wrong analytical solution, which is why it needed to add that error term. We should fix this and add the right expression.