idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 18 forks source link

Issues with verification case 1.b #87

Closed chaibhave closed 5 months ago

chaibhave commented 7 months ago

Bug Description

  1. MOOSE input file
    1. The Line sampler vector PostProcessor should plot the full distance that we use in the verification with the appropriate resolution. Ideally the lineplot should only output on a specific timestep, since we are currently generating a very large number of line plot files.
    2. The PostProcessor flux_point2 should be at 0.5 m not 0.2 m, to be consistent with the documentation and Python script.
  2. Python script
    1. Running the Python script against the gold csv file generates a plot where the analytical and numerical solutions don't match. The gold folder line plot matches the analytical equation at time 50 s, but the documentation and Python script use 25 s. The Python script should be tested against the output from the actual input file to ensure transparency in our verification results.

      Comparsion against gold with time 25 seconds in analytical solution (As claimed in documentation)

      ver-1b_comparison_dist_25s

      Comparsion against gold with time 50 seconds in analytical solution (What actually matches the gold csv plot)

      ver-1b_comparison_dist_50s

Steps to Reproduce

Run the MOOSE simulation and Python script as is from devel.

Impact

Fixing this will ensure that the verification test is run accurately, and is run on an output files that the user can verify the inputs of. We shouldn't be running verifications on gold files as this creates a black box situation.

chaibhave commented 7 months ago

@simopier @cticenhour