search

idaholab / blackbear

BlackBear is a MOOSE-based code for simulating degradation processes in concrete and other structural materials.
GNU Lesser General Public License v2.1
17 stars 42 forks source link

Regold non-affine tests #258

Closed lindsayad closed 3 years ago

lindsayad commented 3 years ago

In libmesh/libmesh#2997 we greatly tightened the affine map detection tolerance. Affine map detection is mean to be an optimization only: it should not affect results. However, previously our detection tolerance was too loose such that we were introducing errors roughly of order 1e-6 into results for slightly deformed meshes, e.g. we would define an element as affine when it was slightly deformed when we should have been defining it as non-affine. With the new tightening of affine detection we are generating results that are more accurate (albeit a bit more slowly!)

lindsayad commented 3 years ago

This is the non-AD version of #250

moosebuild commented 3 years ago

Job Test on 8153d6f wanted to post the following:

View the site here

This comment will be updated on new commits.

lindsayad commented 3 years ago

@bwspenc is there anyone else on the ccb for blackbear other than you? Anyway, it would be cool to get a review on this in not too long since MOOSE next is currently broken

bwspenc commented 3 years ago

Sorry, just saw this. Yes, there are others on the CCB: Antonio, Lynn, Will, Sudipta.