idaholab / blackbear

BlackBear is a MOOSE-based code for simulating degradation processes in concrete and other structural materials.
GNU Lesser General Public License v2.1
17 stars 42 forks source link

Update NEML to newest version #293

Closed reverendbedford closed 2 years ago

reverendbedford commented 2 years ago

I finally eliminated error codes in NEML, so the interface here needs to change slightly. This PR:

moosebuild commented 2 years ago

Job Test on 1402f8b wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 2 years ago

Job Coverage on 1402f8b wanted to post the following:

Coverage

5957ee #293 1402f8
Total Total +/- New
Rate 95.92% 95.70% -0.22% 40.00%
Hits 1294 1291 -3 4
Misses 55 58 +3 6

Diff coverage report

Full coverage report

Warnings

This comment will be updated on new commits.

dschwen commented 2 years ago

This is nice. I'll approve this (if you want to fix the typo) whenever you're ready.

reverendbedford commented 2 years ago

Thanks, yes I fixed the typo just now.

bwspenc commented 2 years ago

Any reason we shouldn't merge this? I see that the 'updated' typo is still there in this version, but other than that, it looks fine.

dschwen commented 2 years ago

Looks like @reverendbedford just forgot to push. I'll merge now. This can be fixed later.