search

idaholab / blackbear

BlackBear is a MOOSE-based code for simulating degradation processes in concrete and other structural materials.
GNU Lesser General Public License v2.1
17 stars 42 forks source link

Add ConcreteMoistureTimeIntegrationMassLumped #328

Closed bwspenc closed 1 year ago

bwspenc commented 1 year ago

closes #327

moosebuild commented 1 year ago

Job Test on 5ca4fa7 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 1 year ago

Job Coverage on 5ca4fa7 wanted to post the following:

Coverage

5c5056 #328 5ca4fa
Total Total +/- New
Rate 94.00% 94.28% +0.27% 100.00%
Hits 1348 1367 +19 21
Misses 86 83 -3 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

jiangwen84 commented 1 year ago

Looks good. Only one minor comment.

bwspenc commented 1 year ago

Looks good. Only one minor comment.

Thanks, @jiangwen84 ! I can't see your comment for some reason. If you can point me to that, that would be great.

jiangwen84 commented 1 year ago

@bwspenc I do not think I have the right to merge it. It looks good to me. You can have someone to merge it.

moosebuild commented 1 year ago

Job Precheck on 18241a0 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/blackbear/docs/PRs/328/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 5c50563f716c8ac3ca4a0e97610526bea90b1282