idaholab / blackbear

BlackBear is a MOOSE-based code for simulating degradation processes in concrete and other structural materials.
GNU Lesser General Public License v2.1
17 stars 42 forks source link

NonUnity Directory Logic may be incorrect for apps depending on Blackbear #375

Closed permcody closed 8 months ago

permcody commented 8 months ago

Bug Description

The Makefile in Blackbear contains the logic to set the non_unity sources for Blackbear, which is used by app.mk in MOOSE. When Blackbear is used as a submodule though, we do not include Blackbear's Makefile and miss that logic. This impacts the unity directories when compiling Blackbear versus an upstream code.

Steps to Reproduce

This can be inspected by printing the $(app_non_unity_variable) from app.mk when compiling an upstream application from Blackbear such as Grizzly or Mastodon.

Impact

Minor now, but impacting the ability to turn on additional unity directories for all applications.