idaholab / blackbear

BlackBear is a MOOSE-based code for simulating degradation processes in concrete and other structural materials.
GNU Lesser General Public License v2.1
17 stars 42 forks source link

Damage Plasticity Model #394

Closed vprithiv closed 2 months ago

vprithiv commented 3 months ago

ref #184

The initial implementation of the damaged plasticity model showed promise for modeling graphite tests but exhibited several discrepancies compared to behaviors documented in the literature (Lee and Fenves, 1998). This PR addresses these issues by thoroughly reviewing and comparing the BlackBear implementation with the published formulation and making necessary corrections and improvements.

Changes Made

  1. Decoupled the calculations of the elastoplastic response and the damage response.
  2. Implemented undamaged strength functions and their derivatives.
  3. Modified the definitions of key constants.
  4. Corrected the implementation of the plastic consistency parameter.
  5. Amended the inaccurate assignment of strength quantity in the yield function equation.

These modifications have resulted in a more accurate and reliable model.

moosebuild commented 3 months ago

Job Documentation on 6e45724 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 3 months ago

Job Coverage on 6e45724 wanted to post the following:

Coverage

61ffc4 #394 6e4572
Total Total +/- New
Rate 93.76% 93.70% -0.06% 96.47%
Hits 1908 1904 -4 82
Misses 127 128 +1 3

Diff coverage report

Full coverage report

This comment will be updated on new commits.

moosebuild commented 2 months ago

Job Precheck on a8919b1 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/blackbear/docs/PRs/394/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 61ffc4aa3036c02e665d0b2d5fb7f3b24f7dc359

bwspenc commented 2 months ago

@vprithiv I just pushed an update that addresses the few minor remaining issues. Assuming the tests pass I'll merge this once they pass.